WordPress.org

GlotPress

Opened 2 years ago

Closed 12 months ago

Last modified 12 months ago

#177 closed enhancement (fixed)

Translaton set sort order

Reported by: usermrpapa Owned by: markoheijnen
Milestone: 1.0 Priority: normal
Version: 0.1 Component: interface
Keywords: Cc:

Description

It would be nice to be able to change the sort order of translations for project instead of it always being by current count. it seems to confuse a lot of users.

a simple filter allows users to customize the sort to their liking.

patch attached.

Attachments (1)

sorting.patch (740 bytes) - added by usermrpapa 2 years ago.

Download all attachments as: .zip

Change History (8)

usermrpapa2 years ago

comment:1 scribu18 months ago

  • Keywords needs-patch added; has-patch removed
  • Milestone 1.0 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

The patch doesn't work because the filter is outside the lambda. You'd need to:

a) convert it to a proper function first and then add the filter inside it
b) apply the filter to the callback, so outside the lambda

I also think that just having two options, alphabetical and translation count, would be enough.

In general, I think #181 has a better approach, so marking as duplicate.

comment:2 usermrpapa18 months ago

not sure why you think it wont work... running on our site and working perfectly... users love it much better... "outside the lambda"???

no issue though if the other ticket gets incorporated, but alas not yet...

Last edited 18 months ago by usermrpapa (previous) (diff)

comment:3 usermrpapa18 months ago

  • Keywords has-patch 2nd-opinion added
  • Resolution duplicate deleted
  • Status changed from closed to reopened

comment:4 usermrpapa18 months ago

  • Keywords needs-patch removed

comment:5 scribu18 months ago

  • Keywords has-patch removed

Yeah, I guess it does work, but you're essentially manipulating PHP code as a string, which is BAD.

So, yes, it does need a new patch.

comment:6 markoheijnen12 months ago

  • Owner set to markoheijnen
  • Resolution set to fixed
  • Status changed from reopened to closed

In 756:

Add filter to the translation sites of a project. So people can filter/order it. Fixes #177

comment:7 markoheijnen12 months ago

  • Keywords 2nd-opinion removed
  • Milestone set to 1.0
Note: See TracTickets for help on using tickets.