Opened 3 years ago

Closed 7 months ago

#92 closed enhancement (fixed)

Show references without links when there is no source file URL

Reported by: dimadin Owned by: nacin
Priority: normal Milestone: 1.0
Component: interface Version:
Keywords: has-patch commit Cc: tracs@…

Description

Some projects are not public so we can't have links that point to source file. In those cases, we can only show file name and line without link since it could provide some context to translator.

Current example of usage is with translations of wpcom and gravatar. Although whole source of wpcom is not public, most parts of it (WP, bbPress, themes, plugins) are, so translators could see where string is used and see source file via detour. On gravatar, file names are descriptive and sometimes match URL structure so translator could guess where to find string in usage.

To add this functionality, function references in gp-template/helper-functions.php needs to be edited.

Attachments (2)

references_without_urls.patch (747 bytes) - added by dimadin 2 years ago.
references_without_urls_2.patch (861 bytes) - added by dimadin 2 years ago.

Download all attachments as: .zip

Change History (7)

  • Milestone set to 1.0
  • Keywords has-patch added

I have to patches for this. Difference between this is that they have different hooks. I made one then I thought about better solution.

Since some project can be proprietary so admins might not want to reveal file names, I added hook to override it.

  • Keywords commit 2nd-opinion added

A hook is nice, but not necessary, as this information would be publicly shown in the PO file anyway.

  • Keywords 2nd-opinion removed
  • Owner set to nacin
  • Status changed from new to accepted
  • Resolution set to fixed
  • Status changed from accepted to closed

(In [724]) Show references without links when there is no source file URL. props dimadin. fixes #92.

Note: See TracTickets for help on using tickets.