#177 closed enhancement (fixed)
Translaton set sort order
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 1.0 |
| Component: | interface | Version: | 0.1 |
| Keywords: | Cc: |
Description
It would be nice to be able to change the sort order of translations for project instead of it always being by current count. it seems to confuse a lot of users.
a simple filter allows users to customize the sort to their liking.
patch attached.
Attachments (1)
Change History (8)
usermrpapa — 16 months ago
- Keywords needs-patch added; has-patch removed
- Milestone 1.0 deleted
- Resolution set to duplicate
- Status changed from new to closed
comment:2
usermrpapa — 7 months ago
not sure why you think it wont work... running on our site and working perfectly... users love it much better... "outside the lambda"???
no issue though if the other ticket gets incorporated, but alas not yet...
comment:3
usermrpapa — 7 months ago
- Keywords has-patch 2nd-opinion added
- Resolution duplicate deleted
- Status changed from closed to reopened
comment:4
usermrpapa — 7 months ago
- Keywords needs-patch removed
- Keywords has-patch removed
Yeah, I guess it does work, but you're essentially manipulating PHP code as a string, which is BAD.
So, yes, it does need a new patch.
comment:6
markoheijnen — 3 weeks ago
- Owner set to markoheijnen
- Resolution set to fixed
- Status changed from reopened to closed
In 756:
comment:7
markoheijnen — 3 weeks ago
- Keywords 2nd-opinion removed
- Milestone set to 1.0
Note: See
TracTickets for help on using
tickets.
The patch doesn't work because the filter is outside the lambda. You'd need to:
a) convert it to a proper function first and then add the filter inside it
b) apply the filter to the callback, so outside the lambda
I also think that just having two options, alphabetical and translation count, would be enough.
In general, I think #181 has a better approach, so marking as duplicate.