Ticket #120: fix-incorrect-translation-lists.diff

translation.php

@@ -117 +117 @@
                 }
                 if ( $all_in ) {
                         $statuses_where = array();
+
+                        if ( !in_array( gp_array_get( $filters, 'translated' ), array( 'yes', 'no' ) ) )
+                                $statuses_where[] = 't.status IS NULL';
+
                         foreach( $statuses as $single_status ) {
                                 $statuses_where[] = $gpdb->prepare( 't.status = %s', $single_status );
                         }
                         $statuses_where = '(' . implode( ' OR ', $statuses_where ) . ')';
-                        $join_where[] = $statuses_where;
-                        /*
-                                usually we want the status to be part of the ON clause, because we want to include
-                                the untranslated strings in the listing. This, however is not the case if the filter
-                                explictly forbids untranslated strings
-                        */
-                        if ( 'no' == gp_array_get( $filters, 'translated' ) ) {
+
+                        if ( 'no' == gp_array_get( $filters, 'translated' ) )
+                                $join_where[] = $statuses_where;
+                        else
                                 $where[] = $statuses_where;
-                        }
                 }
                 
                 $where = implode( ' AND ', $where );